Re: [PATCH 03/15] staging: r8188eu: remove test code for efuse shadow map

[Dan Carpenter]

On Mon, Nov 15, 2021 at 02:50:44PM +0100, Martin Kaiser wrote:
> Hi Dan,
> 
> Thus wrote Dan Carpenter (dan.carpenter@xxxxxxxxxx):
> 
> > On Sat, Nov 13, 2021 at 07:55:06PM +0100, Martin Kaiser wrote:
> 
> > > -			if (_SUCCESS == ret)
> > > -				goto exit;
> > > -		}
> > > +		if (_SUCCESS == ret)
> > > +			return;
> > >  	}
> > > -	Hal_EfuseReadEFuse88E(Adapter, _offset, _size_byte, pbuf, bPseudoTest);
> 
> > It looks like this changes how the code works here.  Originally we
> > called Hal_EfuseReadEFuse88E() fir rtw_IOL_applied() was false or if
> > iol_read_efuse() failed.
> 
> the call to Hal_EfuseReadEFuse88E is still there, it's below the part
> that you quoted:
> 
> -       Hal_EfuseReadEFuse88E(Adapter, _offset, _size_byte, pbuf, bPseudoTest);
> -
> -exit:
> -       return;
> -}
>  
> -static void ReadEFuse_Pseudo(struct adapter *Adapter, u16 _offset, u16 _size_byte, u8 *pbuf, bool bPseudoTest)
> -{
> -       Hal_EfuseReadEFuse88E(Adapter, _offset, _size_byte, pbuf, bPseudoTest);
> +       Hal_EfuseReadEFuse88E(Adapter, _offset, _size_byte, pbuf);
>  }
> 
> The removal of ReadEFuse_Pseudo makes the diff a bit confusing. When I
> checked the patches before posting, I stumbled across this part as well.

Oh...  Sorry.  I should have seen that.  Thanks!

regards,
dan carpenter