Re: [PATCH 1/3] serial: liteuart: fix compile testing

From: Stafford Horne
Date: Mon Nov 15 2021 - 19:12:53 EST


On Mon, Nov 15, 2021 at 02:37:43PM +0100, Johan Hovold wrote:
> Allow the liteuart driver to be compile tested by fixing the broken
> Kconfig dependencies.
>
> Fixes: 1da81e5562fa ("drivers/tty/serial: add LiteUART driver")
> Cc: stable@xxxxxxxxxxxxxxx # 5.11
> Cc: Filip Kokosinski <fkokosinski@xxxxxxxxxxxx>
> Cc: Mateusz Holenko <mholenko@xxxxxxxxxxxx>
> Cc: Stafford Horne <shorne@xxxxxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

Reviewed-by: Stafford Horne <shorne@xxxxxxxxx>

> ---
> drivers/tty/serial/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 6ff94cfcd9db..67de892e0947 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1531,9 +1531,9 @@ config SERIAL_MILBEAUT_USIO_CONSOLE
>
> config SERIAL_LITEUART
> tristate "LiteUART serial port support"
> + depends on LITEX || COMPILE_TEST
> depends on HAS_IOMEM
> - depends on OF || COMPILE_TEST
> - depends on LITEX
> + depends on OF
> select SERIAL_CORE
> help
> This driver is for the FPGA-based LiteUART serial controller from LiteX
> --
> 2.32.0
>