Re: [net: PATCH] net: mvmdio: fix compilation warning

[Marcin Wojtas]

Hi Andrew,


pon., 15 lis 2021 o 20:35 Andrew Lunn <andrew@xxxxxxx> napisał(a):
>
> On Mon, Nov 15, 2021 at 04:30:24PM +0100, Marcin Wojtas wrote:
> > The kernel test robot reported a following issue:
> >
> > >> drivers/net/ethernet/marvell/mvmdio.c:426:36: warning:
> > unused variable 'orion_mdio_acpi_match' [-Wunused-const-variable]
> >    static const struct acpi_device_id orion_mdio_acpi_match[] = {
>
> How come OF never gives these warning, just ACPI? If there something
> missing in ACPI which OF has?

It was enough to compile mvebu_v7_defconfig with W=1 to get it (so
CONFIG_ACPI disabled). There may be a similar case for config _OF, but
I couldn't deselect it easily and compile mvmdio at the same time.

>
> > Fixes: c54da4c1acb1 ("net: mvmdio: add ACPI support")
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Marcin Wojtas <mw@xxxxxxxxxxxx>
>
> Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
>

Thanks,
Marcin