Re: [PATCH 1/2] sh: mcount.S: fix build error when PRINTK is not enabled

[Randy Dunlap]

On 11/15/21 2:10 AM, Geert Uytterhoeven wrote:
> Hi Randy,
>
> On Mon, Nov 15, 2021 at 7:41 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> > Fix a build error in mcount.S when CONFIG_PRINTK is not enabled.
> > Fixes this build error:
> >
> > sh2-linux-ld: arch/sh/lib/mcount.o: in function `stack_panic':
> > (.text+0xec): undefined reference to `dump_stack'
> >
> > Fixes: e460ab27b6c3e ("sh: Fix up stack overflow check with ftrace disabled.")
> > Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > Possibly even more of this function should conditionally not be built...
>
> What about making STACK_DEBUG depend on PRINTK instead?
> It doesn't make much sense to enable the former, if you won't print
> any output...

Hi Geert,
That works. Thanks for the suggestion.

I'll send a v2.
--
~Randy