Re: [PATCH v3 0/7] spi: dw: Cleanup macros/funcs naming and add IP-core version support

From: Serge Semin
Date: Tue Nov 16 2021 - 06:37:58 EST

Hello Mark,

I think Andy is done with reviewing this patchset. If you are ok with
what is introduced here please consider merging the series in.


On Mon, Nov 15, 2021 at 09:19:10PM +0300, Serge Semin wrote:
> I was going to submit a cleanup patchset for the DW SSI driver for a
> long time, but due to lack of free time couldn't make it so far.
> Nandhini's series [1] made me to proceed with this task so mate would
> finally have his patchset accepted and merged into the mainline kernel.
> There are four cleanup patches here and three feature patches. In the
> framework of the former patches we convert the DW SPI driver to using
> module namespaces and provide a better code organization. In particular
> the second part concerns the methods and macros naming unification (using
> a unified prefixes of the code object names) and the CSR fields macro
> implementation using the bitfield helpers available in the kernel. The
> later patches introduce the DW SSI IP-core versions interface so it
> could be used for a version-specific features implementation. Nandhini
> will be mostly interested in the later patches in the framework of his
> series [1].
> Nandhini, could you please test the patchset out on your DWC SSI hardware?
> After it's merged into the spi/for-next branch of the Mark' repository you
> will be able to rebase your series on top of it and use the last IP-core
> version interface for your benefit.
> Andy, I have added your tag to all the patches except the last one since
> it's new (though suggested by you).
> [1]
> Link:
> Changelog v2:
> - Replace "assi" suffixes with "pssi" in the spi-dw-mmio.c methods.
> (Thanks Andy for noticing this pity mistake)
> - Add new patches:
> [PATCH v2 6/6] spi: dw: Replace DWC_HSSI capability with IP-core version checker
> [PATCH v2 1/6] spi: dw: Add symbol namespaces for the core and DMA modules
> - Replace the ASCII-to-integer conversion with a unified IP-core versioning
> interface (Suggested by Andy).
> Link:
> Changelog v3:
> - Discard the symbols importing from the spi-dw-dma object since it's
> linked into the spi-dw-core module anyway thus having the same symbols
> namespace.
> - Move the DW_SPI_CAP_DFS32 capability flag position fix to a separate
> patch.
> Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andy@xxxxxxxxxx>
> Cc: linux-spi@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Serge Semin (7):
> spi: dw: Add a symbols namespace for the core module
> spi: dw: Discard redundant DW SSI Frame Formats enumeration
> spi: dw: Put the driver entities naming in order
> spi: dw: Convert to using the Bitfield access macros
> spi: dw: Introduce Synopsys IP-core versions interface
> spi: dw: Replace DWC_HSSI capability with IP-core version checker
> spi: dw: Define the capabilities in a continuous bit-flags set
> drivers/spi/spi-dw-bt1.c | 9 +-
> drivers/spi/spi-dw-core.c | 175 ++++++++++++++++++++----------------
> drivers/spi/spi-dw-dma.c | 55 ++++++------
> drivers/spi/spi-dw-mmio.c | 22 ++---
> drivers/spi/spi-dw-pci.c | 60 ++++++-------
> drivers/spi/spi-dw.h | 182 ++++++++++++++++++++------------------
> 6 files changed, 271 insertions(+), 232 deletions(-)
> --
> 2.33.0