Re: [PATCH] staging: r8188eu: remove unused defines in wifi.h

From: Dan Carpenter
Date: Tue Nov 16 2021 - 10:12:48 EST

On Tue, Nov 16, 2021 at 06:01:42PM +0300, Pavel Skripkin wrote:
> On 11/16/21 17:18, Dan Carpenter wrote:
> > > I cannot ack, since I am not the maintainer (or even reviewer) of this
> > > driver :) I just saw this BIT() definition and decided to say, that it can
> > > be also removed
> >
> > Just give a Reviewed-by tag... No one is appointed as a maintainer, you
> > just have to start handing our reviewed-by tags until people start to
> > respect your judgement and then you're a maintainer.
> >
> Ok, I will send the R-b tag, since patch looks correct to me as is :)
> I think, I misunderstood what "ack" means. I thought Zameer means Acked-by
> tag, which can sent only by maintainers (Larry and Phillip in case of
> r8188eu), but I was wrong, I guess...

To me Acked by means you approve the patch so it's like, yeah, normally
maintainers use it. But sometimes like people ask for your opinion and
then you can Ack it. Or maybe you just want to express joy about a
feature. (Please feel joy very sparingly. :P).

dan carpenter