Re: [PATCH] xen/privcmd: make option visible in Kconfig
From: Jan Beulich
Date: Tue Nov 16 2021 - 11:05:46 EST
On 16.11.2021 16:01, Juergen Gross wrote:
> On 16.11.21 15:55, Jan Beulich wrote:
>> On 16.11.2021 15:33, Juergen Gross wrote:
>>> This configuration option provides a misc device as an API to userspace.
>>> Make this API usable without having to select the module as a transitive
>>> This also fixes an issue where localyesconfig would select
>>> CONFIG_XEN_PRIVCMD=m because it was not visible and defaulted to
>>> building as module.
>>> Based-on-patch-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
>>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>>> --- a/drivers/xen/Kconfig
>>> +++ b/drivers/xen/Kconfig
>>> @@ -259,9 +259,14 @@ config XEN_SCSI_BACKEND
>>> if guests need generic access to SCSI devices.
>>> config XEN_PRIVCMD
>>> - tristate
>>> + tristate "Xen hypercall passthrough driver"
>>> depends on XEN
>>> default m
>>> + help
>>> + The hypercall passthrough driver allows user land programs to perform
>> Maybe worth adding "privileged" here? Albeit of course that's different
>> from the use of the word ...
> I guess you mean "... allows privileged user programs ..." (another
> variant might be "The privileged hypercall passthrough ...")?
The former, yes.