Re: [PATCH 2/2] mlx5: fix mlx5i_grp_sw_update_stats() stack usage

From: Saeed Mahameed
Date: Tue Nov 16 2021 - 15:51:37 EST


On Mon, 2021-11-08 at 12:10 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The mlx5e_sw_stats structure has grown to the point of triggering
> a warning when put on the stack of a function:
>
> mlx5/core/ipoib/ipoib.c: In function 'mlx5i_grp_sw_update_stats':
> mlx5/core/ipoib/ipoib.c:136:1: error: the frame size of 1028 bytes is
> larger than 1024 bytes [-Werror=frame-larger-than=]
>
> In this case, only five of the structure members are actually set,
> so it's sufficient to have those as separate local variables.
> As en_rep.c uses 'struct rtnl_link_stats64' for this, just use
> the same one here for consistency.
>
> Fixes: def09e7bbc3d ("net/mlx5e: Add HW_GRO statistics")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---

Thanks Arnd, Both patches applied to net-next-mlx5,

Since I will be queuing them up for net-next, I will have to remove the
Fixes tags.