Re: [PATCH v8 3/3] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS

From: Stephen Boyd
Date: Tue Nov 16 2021 - 17:54:40 EST


Quoting Rakesh Pillai (2021-11-02 06:44:33)
> @@ -457,7 +608,13 @@ static int adsp_probe(struct platform_device *pdev)
> if (ret)
> goto free_rproc;
>
> - pm_runtime_enable(adsp->dev);
> + ret = qcom_rproc_pds_attach(adsp->dev, adsp->proxy_pds,
> + desc->proxy_pd_names);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "Failed to attach proxy power domains\n");
> + goto free_rproc;
> + }
> + adsp->proxy_pd_count = ret;

Can we check this against the define so that we don't have more than the
fixed number of power domains and try to access elements beyond the
length of the array?