Re: [PATCH] media: hantro: Avoid global variable for jpeg quantization tables

From: Ezequiel Garcia
Date: Wed Nov 17 2021 - 05:58:40 EST


Hi James,

Thanks for the patch.

On Thu, Nov 11, 2021 at 10:01:08PM +0000, James Cowgill wrote:
> On a system with multiple encoders present, it's possible for two
> encoders to write to the global luma and chroma quantization tables at
> the same time if they both submit a JPEG frame to be encoded. Avoid
> this race by moving the tables into the `jpeg_ctx` structure which is
> stored on the stack.
>
> Signed-off-by: James Cowgill <james.cowgill@xxxxxxxxxx>

Reviewed-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx>