Re: [PATCH v8 11/12] media: hantro: Staticize a struct in postprocessor code

[Ezequiel Garcia]

On Tue, Nov 16, 2021 at 03:38:41PM +0100, Andrzej Pietrasiewicz wrote:
> The struct is not used outside this file, so it can be static.
> 
> Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx>

Reviewed-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx>

> ---
>  drivers/staging/media/hantro/hantro_postproc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/hantro/hantro_postproc.c b/drivers/staging/media/hantro/hantro_postproc.c
> index 4549aec08feb..89de43021779 100644
> --- a/drivers/staging/media/hantro/hantro_postproc.c
> +++ b/drivers/staging/media/hantro/hantro_postproc.c
> @@ -33,7 +33,7 @@
>  #define VPU_PP_OUT_RGB			0x0
>  #define VPU_PP_OUT_YUYV			0x3
>  
> -const struct hantro_postproc_regs hantro_g1_postproc_regs = {
> +static const struct hantro_postproc_regs hantro_g1_postproc_regs = {
>  	.pipeline_en = {G1_REG_PP_INTERRUPT, 1, 0x1},
>  	.max_burst = {G1_REG_PP_DEV_CONFIG, 0, 0x1f},
>  	.clk_gate = {G1_REG_PP_DEV_CONFIG, 1, 0x1},
> -- 
> 2.25.1
>