Re: [PATCH 16/21] ASoC: SOF: topology: Add support for Mediatek AFE DAI

[Daniel Baluta]

On 11/17/21 7:29 PM, Mark Brown wrote:
> On Wed, Nov 17, 2021 at 11:37:29AM +0200, Daniel Baluta wrote:
> > From: YC Hung <yc.hung@xxxxxxxxxxxx>
> >
> > Add new sof dai and config to pass topology file configuration
> > to SOF firmware running on Mediatek platform DSP core.
> > Add mediatek audio front end(AFE) to the list of supported sof_dais
> This breaks an x86 allmodconfig build:
>
> /mnt/kernel/sound/soc/sof/mediatek/mt8195/mt8195.c: In function 'mt8195_run':
> /mnt/kernel/sound/soc/sof/mediatek/mt8195/mt8195.c:207:2: error: implicit declaration of function 'sof_hifixdsp_boot_sequence' [-Werror=implicit-function-declaration]
>    207 |  sof_hifixdsp_boot_sequence(sdev, adsp_bootup_addr);
>        |  ^~~~~~~~~~~~~~~~~~~~~~~~~~
> At top level:
> /mnt/kernel/sound/soc/sof/mediatek/mt8195/mt8195.c:201:12: error: 'mt8195_run' defined but not used [-Werror=unused-function]
>    201 | static int mt8195_run(struct snd_sof_dev *sdev)
>        |            ^~~~~~~~~~
> cc1: all warnings being treated as errors
>
> _boot_sequence is added in "ASoC: SOF: mediatek: Add fw loader and
> mt8195 dsp ops to load firmware" which is later in the series.
>
> mt8195_run should be either global, a static inline or not declared in
> the header at all.


YC,

Please send a fix for this on top of topic/sof-dev. I will take care of 
the squash and resend.