Re: [PATCH 2/2] KVM: x86/mmu: Pass parameter flush as false in kvm_tdp_mmu_zap_collapsible_sptes()

[Paolo Bonzini]

On 11/17/21 18:50, Ben Gardon wrote:
> > Since tlb flush has been done for legacy MMU before
> > kvm_tdp_mmu_zap_collapsible_sptes(), so the parameter flush
> > should be false for kvm_tdp_mmu_zap_collapsible_sptes().
> >
> > Fixes: e2209710ccc5d ("KVM: x86/mmu: Skip rmap operations if rmaps not allocated")
> > Signed-off-by: Hou Wenlong<houwenlong93@xxxxxxxxxxxxxxxxx>
> Haha, I'm glad we're thinking along similar lines. I just sent a patch
> yesterday to remove the flush parameter from that function entirely:
> https://lore.kernel.org/lkml/20211115234603.2908381-2-bgardon@xxxxxxxxxx/
> I'll CC you on that patch.

And actually I had applied that before reading Sean's answer, so his 
follow up is not needed anymore.

Paolo