Re: [PATCH bpf] selftests: bpf: check map in map pruning
From: Andrii Nakryiko
Date: Wed Nov 17 2021 - 20:29:41 EST
On Wed, Nov 17, 2021 at 5:01 PM Alexei Starovoitov
<alexei.starovoitov@xxxxxxxxx> wrote:
>
> On Wed, Nov 17, 2021 at 08:47:45AM +0000, Lorenz Bauer wrote:
> > On Sat, 13 Nov 2021 at 01:27, Alexei Starovoitov
> > <alexei.starovoitov@xxxxxxxxx> wrote:
> > >
> > > Not sure how you've tested it, but it doesn't work in unpriv:
> > > $ test_verifier 789
> > > #789/u map in map state pruning FAIL
> > > processed 26 insns (limit 1000000) max_states_per_insn 0 total_states
> > > 2 peak_states 2 mark_read 1
> > > #789/p map in map state pruning OK
> >
> > Strange, I have a script that I use for bisecting which uses a minimal
> > .config + virtue to run a vm, plus I was debugging in gdb at the same
> > time. I might have missed this, apologies.
> >
> > I guess vmtest.sh is the canonical way to run tests now?
>
> vmtest.sh runs test_progs only. That's the minimum bar that
It runs test_progs by default, unless something else is requested. You
can run anything inside it, e.g.:
./vmtest.sh -- ./test_maps
BTW, we recently moved configs around in libbpf repo on Github, so
this script broke. I'm sending a fix in a few minutes, hopefully.
> developers have to pass before sending patches.
> BPF CI runs test_progs, test_progs-no_alu32, test_verifier and test_maps.
> If in doubt run them all.