Re: [PATCH v1 1/3] media: staging: tegra-vde: Support reference picture marking

From: Dan Carpenter
Date: Thu Nov 18 2021 - 01:53:57 EST


On Wed, Nov 17, 2021 at 10:21:00PM -0800, Joe Perches wrote:
> On Thu, 2021-11-18 at 09:14 +0300, Dan Carpenter wrote:
> > It's not hard to run Smatch yourself...
> >
> > Depending on if you're on a apt distro or yum distro then fetch the
> > dependencies with one of the follow commands:
> > apt-get install gcc make sqlite3 libsqlite3-dev libdbd-sqlite3-perl libssl-dev libtry-tiny-perl
> > yum install gcc make sqlite3 sqlite-devel sqlite perl-DBD-SQLite openssl-devel perl-Try-Tiny
> >
> > git clone https://github.com/error27/smatch
> > cd smatch
> > make
> > cd ~/kernel_source/
> > ~/smatch/smatch_scripts/kchecker drivers/subsystem/
>
> Might want to stick something in Documentation about that.
>

That's a good idea. I was trying to figure out where it should go and
I looked at Documentation/process/submit-checklist.rst and point 4 had
me a bit puzzled:

4) ppc64 is a good architecture for cross-compilation checking because it
tends to use ``unsigned long`` for 64-bit quantities.

It took me a while to realize that this must have been written when 64
bit systems were new and rare. :P This documentation is old old old...

regards,
dan carpenter