Re: [PATCH] drm/scheduler: fix drm_sched_job_add_implicit_dependencies harder

From: Christian König
Date: Thu Nov 18 2021 - 01:59:42 EST

Am 18.11.21 um 04:09 schrieb Rob Clark:
On Wed, Nov 17, 2021 at 5:23 PM Steev Klimaszewski <steev@xxxxxxxx> wrote:

On 11/17/21 1:27 AM, Christian König wrote:
Am 16.11.21 um 19:30 schrieb Amit Pundir:
On Tue, 16 Nov 2021 at 21:21, Rob Clark <robdclark@xxxxxxxxx> wrote:
From: Rob Clark <robdclark@xxxxxxxxxxxx>

drm_sched_job_add_dependency() could drop the last ref, so we need
to do
the dma_fence_get() first.

It fixed the splats I saw on RB5 (sm8250 | A650). Thanks.

Tested-by: Amit Pundir <amit.pundir@xxxxxxxxxx>
I've added my rb, pushed this with the original fix to drm-misc-fixes
and cleaned up the obvious fallout between drm-misc-fixes and
drm-misc-next in drm-tip.

Thanks for the help and sorry for the noise,

I've run into this splat on the Lenovo Yoga C630 on 5.16-rc1 - are these
2 patches (which fix it) going to be heading to 5.16 or were they
targeted at 5.17?
these should be for v5.16

Yeah, they are already queued up for -rc2.