Re: [PATCH 5.15 000/923] 5.15.3-rc3 review

[Peter Zijlstra]

On Wed, Nov 17, 2021 at 03:50:17PM -0800, Linus Torvalds wrote:

> I really don't think the WCHAN code should use unwinders at all. It's
> too damn fragile, and it's too easily triggered from user space.

On x86, esp. with ORC, it pretty much has to. The thing is, the ORC
unwinder has been very stable so far. I'm guessing there's some really
stupid thing going on, like for example trying to unwind a freed stack.

I *just* managed to reproduce, so let me go have a poke.

> So I think we need to revert all the wchan changes. Not just in
> stable, but in mainline too.

Sure, we can do that. Want a pull request for that or will you just kill
them outright?