Re: [PATCH] x86/paravirt: Fix build PARAVIRT_XXL=y without XEN_PV

From: Borislav Petkov
Date: Thu Nov 18 2021 - 04:13:59 EST


On Wed, Nov 17, 2021 at 05:26:15PM -0800, Sathyanarayanan Kuppuswamy wrote:
> I meant it not scalable because, for any new use case of HLT
> instruction, it would need substitution again. We cannot always keep
> tracking its uses in the future, right?

I don't understand what the whole hoopla is about:

alternative_call(halt, tdx_halt, X86_FEATURE_TDX_GUEST, ...)

No PV needed.

> Also, If we make any changes to the core emulation code (like arguments
> change), we will have to re-touch these use cases to handle it.

We do change the core code all the time to accomodate new stuff. You
should be seeing that constantly with the rate of change happening...

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette