[PATCH net v2] net: marvell: prestera: fix brige port operation

From: Volodymyr Mytnyk
Date: Thu Nov 18 2021 - 14:49:48 EST

From: Volodymyr Mytnyk <vmytnyk@xxxxxxxxxxx>

Return NOTIFY_DONE (dont't care) for switchdev notifications
that prestera driver don't know how to handle them.

With introduction of SWITCHDEV_BRPORT_[UN]OFFLOADED switchdev
events, the driver rejects adding swport to bridge operation
which is handled by prestera_bridge_port_join() func. The root
cause of this is that prestera driver returns error (EOPNOTSUPP)
in prestera_switchdev_blk_event() handler for unknown swdev
events. This causes switchdev_bridge_port_offload() to fail
when adding port to bridge in prestera_bridge_port_join().

Fixes: 957e2235e526 ("net: make switchdev_bridge_port_{,unoffload} loosely coupled with the bridge")
Signed-off-by: Volodymyr Mytnyk <vmytnyk@xxxxxxxxxxx>

Changes in V2:
- Split changes into two independent commits:
- fix prestera_switchdev_blk_event() handler (THIS PATCH)
- fix error path handling in prestera_bridge_port_join() (NEW)
- Updated fix tags in both patches according to review comments
- Fix commit messages in both patches

drivers/net/ethernet/marvell/prestera/prestera_switchdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c
index 3ce6ccd0f539..79f2fca0d412 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_switchdev.c
@@ -1124,7 +1124,7 @@ static int prestera_switchdev_blk_event(struct notifier_block *unused,
- err = -EOPNOTSUPP;
+ return NOTIFY_DONE;

return notifier_from_errno(err);