Re: [PATCH] intersil: Use struct_group() for memcpy() region

From: Kees Cook
Date: Thu Nov 18 2021 - 15:25:24 EST


On Thu, Nov 18, 2021 at 08:46:11PM +0100, Johannes Berg wrote:
> On Thu, 2021-11-18 at 10:41 -0800, Kees Cook wrote:
> >
> > /* 802.11 */
> > - __le16 frame_control; /* parts not used */
> > - __le16 duration_id;
> > - u8 addr1[ETH_ALEN];
> > - u8 addr2[ETH_ALEN]; /* filled by firmware */
> > - u8 addr3[ETH_ALEN];
> > - __le16 seq_ctrl; /* filled by firmware */
> > + struct_group(frame,
>
> Arguably, that should be 'header' rather than 'frame' :)

Works for me. :) I will rename it. Thanks!

--
Kees Cook