Re: [PATCH v1 01/19] lib/string_helpers: Introduce kasprintf_strarray()

From: Bartosz Golaszewski
Date: Thu Nov 18 2021 - 15:30:29 EST


On Thu, Nov 18, 2021 at 5:56 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Mon, Nov 15, 2021 at 01:23:02PM +0200, Andy Shevchenko wrote:
> > On Tue, Nov 09, 2021 at 12:42:00PM +0100, Linus Walleij wrote:
> > > On Fri, Nov 5, 2021 at 1:43 PM Andy Shevchenko
> > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > >
> > > > We have a few users already that basically want to have array of
> > > > sequential strings to be allocated and filled.
> > > >
> > > > Provide a helper for them (basically adjusted version from gpio-mockup.c).
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > >
> > > Fulfils Rusty Russell's API design hierarchy requirements
> > > and help people to make less mistakes so:
> > > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> >
> > Thanks!
> >
> > Should I resend, take into mine PR, or you just apply it as is?
> >
> > As I answered previously the series doesn't require additional work
> > from my perspective.
>
> Okay, I'm about to send a PR to you and Bart for this.
> Does it sound good?
>

Sounds good to me.

Bart