RE: [agd5f:drm-next 51/92] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:6: warning: no previous prototype for function 'amdgpu_amdkfd_gpuvm_unpin_bo'

From: Errabolu, Ramesh
Date: Thu Nov 18 2021 - 16:52:18 EST

[AMD Official Use Only]


Could you advise if I should submit a patch to fix the warning. The api under question (amdgpu_amdkfd_gpuvm_unpin_bo) MUST be non-static in DKMS branch. However it could be specified as static on drm-next. What is the policy under such situations. Let me know.


-----Original Message-----
From: kernel test robot <lkp@xxxxxxxxx>
Sent: Thursday, November 18, 2021 2:00 PM
To: Errabolu, Ramesh <Ramesh.Errabolu@xxxxxxx>
Cc: llvm@xxxxxxxxxxxxxxx; kbuild-all@xxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Kuehling, Felix <Felix.Kuehling@xxxxxxx>
Subject: [agd5f:drm-next 51/92] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:6: warning: no previous prototype for function 'amdgpu_amdkfd_gpuvm_unpin_bo'

[CAUTION: External Email]

tree:;;sdata=K8TrE3DWtsNrw4qWrttGfGdL71w3w9Gv1KUCOq1zWHk%3D&amp;reserved=0 drm-next
head: eaae0714f4a82df81a60c6aae74c568e8974a716
commit: f140fc51a32ef8637b522a880b8f9f14683ce8df [51/92] drm/amdgpu: Pin MMIO/DOORBELL BO's in GTT domain
config: x86_64-randconfig-r001-20211118 (attached as .config) reproduce (this is a W=1 build):
wget;;sdata=OEvXACWiWtGXk1em3DdxFBHWJEQ8InliJUbr9FLoKbU%3D&amp;reserved=0 -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add agd5f;;sdata=Mc0JG24aLBE%2B%2Bo073hnBipZMP8LicS3oeiXufr3h4Bo%3D&amp;reserved=0
git fetch --no-tags agd5f drm-next
git checkout f140fc51a32ef8637b522a880b8f9f14683ce8df
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:6: warning: no
>> previous prototype for function 'amdgpu_amdkfd_gpuvm_unpin_bo'
>> [-Wmissing-prototypes]
void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:1335:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
1 warning generated.

vim +/amdgpu_amdkfd_gpuvm_unpin_bo +1335 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c

1327 /**
1328 * amdgpu_amdkfd_gpuvm_unpin_bo() - Unpins BO using following criteria
1329 * @bo: Handle of buffer object being unpinned
1330 *
1331 * - Is a illegal request for USERPTR BOs and is ignored
1332 * - All other BO types (GTT, VRAM, MMIO and DOORBELL) will have their
1333 * PIN count decremented. Calls to UNPIN must balance calls to PIN
1334 */
> 1335 void amdgpu_amdkfd_gpuvm_unpin_bo(struct amdgpu_bo *bo)
1336 {
1337 int ret = 0;
1339 ret = amdgpu_bo_reserve(bo, false);
1340 if (unlikely(ret))
1341 return;
1343 amdgpu_bo_unpin(bo);
1344 amdgpu_bo_unreserve(bo);
1345 }

0-DAY CI Kernel Test Service, Intel Corporation;;sdata=iNtsNcsj43m1oShIaDr3W%2FVTj0uSOtcI2RU9u04CuDA%3D&amp;reserved=0