Re: [PATCH] spi: docs: improve the SPI userspace API documentation

From: Javier Martinez Canillas
Date: Fri Nov 19 2021 - 03:16:22 EST


Hello Geert

On 11/19/21 09:10, Geert Uytterhoeven wrote:
> Hi Javier,
>
> On Thu, Nov 18, 2021 at 10:32 PM Javier Martinez Canillas
> <javierm@xxxxxxxxxx> wrote:
>> This doc is fairly outdated and only uses legacy device instantiation
>> terminology. Let us update it and also mention the OF and ACPI device
>> tables, to make easier for users to figure out how should be defined.
>>
>> Also, mention that devices bind could be done in user-space now using
>> the "driver_override" sysfs entry.
>>
>> Suggested-by: Ralph Siemsen <ralph.siemsen@xxxxxxxxxx>
>> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
>
> Thanks for your patch!
>

You are welcome!

[snip]

>> +
>> +NOTE: it used to be supported to define an SPI device using the "spidev"
>> + name. For example as .modalias = "spidev" or compatible = "spidev".
>> + But this is no longer supported by the Linux kernel and instead a
>> + real SPI device name as listed in one of the tables should be used.
>
> This reads as the tables are fixed.
> Perhaps add
>
> You are encouraged to add an entry for your SPI device name to
> one of the tables.
>

Indeed, you are correct. I'll add that too in v2.

Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat