Re: [PATCH v1 0/2] serial: 8250_pci: Split Pericom driver

[Jay Dolan]

On 11/19/21 12:23 AM, Andy Shevchenko wrote:
> On Thu, Nov 18, 2021 at 10:32:51PM -0800, Jay Dolan wrote:
> > On 11/17/21 6:57 AM, Andy Shevchenko wrote:
> > > Split Pericom driver to a separate module.
> > > While at it, re-enable high baud rates.
> > >
> > > Jay, can you, please, test this on as many hardware as you have?
> > >
> > > The series depends on the fix-series: https://lore.kernel.org/linux-serial/20211117145502.43645-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/#u
>
> > I have my current state here: https://github.com/accesio/linux/blob/split-pericom-driver/drivers/tty/serial/8250/8250_pericom.c
> >
> > * Change port type to UPIO_PORT
> > * Add in pericom_do_startup() because the UPF_MAGIC_MULTIPLIER doesn't
> > stick.
>
> Thanks, I have updated my local tree with these changes.
>
> > When I'm testing baud rates greater than baud_base I'm seeing strange things
> > on the scope.
>
> Can you confirm that there are no issues with the first (fixes) series?
Yes. The fixes series has no issues, and was tested up to baud_base for 
both 14 and 24 MHz crystals.
> I have slightly changed your set_divisor() refactoring, it may be that issue
> is there.
>
> > Maybe I'm just tired, and it's human error. I should be able
> > to get back to it and get it done on Saturday.
>
> Thank you.