Re: [PATCH v2 7/9] locking/rwlocks: introduce write_lock_nested
From: kernel test robot
Date: Fri Nov 19 2021 - 22:51:52 EST
Hi Minchan,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/master]
[also build test ERROR on linux/master linus/master v5.16-rc1]
[cannot apply to hnaz-mm/master tip/locking/core next-20211118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Minchan-Kim/zsmalloc-remove-bit_spin_lock/20211116-030720
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 8ab774587903771821b59471cc723bba6d893942
config: nds32-randconfig-r003-20211115 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c24db750268d85953fe12742e6e4a7b8baf16623
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Minchan-Kim/zsmalloc-remove-bit_spin_lock/20211116-030720
git checkout c24db750268d85953fe12742e6e4a7b8baf16623
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=nds32
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
kernel/locking/spinlock.c:68:17: warning: no previous prototype for '__raw_spin_lock' [-Wmissing-prototypes]
68 | void __lockfunc __raw_##op##_lock(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:126:1: note: in expansion of macro 'BUILD_LOCK_OPS'
126 | BUILD_LOCK_OPS(spin, raw_spinlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c:80:26: warning: no previous prototype for '__raw_spin_lock_irqsave' [-Wmissing-prototypes]
80 | unsigned long __lockfunc __raw_##op##_lock_irqsave(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:126:1: note: in expansion of macro 'BUILD_LOCK_OPS'
126 | BUILD_LOCK_OPS(spin, raw_spinlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c:98:17: warning: no previous prototype for '__raw_spin_lock_irq' [-Wmissing-prototypes]
98 | void __lockfunc __raw_##op##_lock_irq(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:126:1: note: in expansion of macro 'BUILD_LOCK_OPS'
126 | BUILD_LOCK_OPS(spin, raw_spinlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c:103:17: warning: no previous prototype for '__raw_spin_lock_bh' [-Wmissing-prototypes]
103 | void __lockfunc __raw_##op##_lock_bh(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:126:1: note: in expansion of macro 'BUILD_LOCK_OPS'
126 | BUILD_LOCK_OPS(spin, raw_spinlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c:68:17: warning: no previous prototype for '__raw_read_lock' [-Wmissing-prototypes]
68 | void __lockfunc __raw_##op##_lock(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:129:1: note: in expansion of macro 'BUILD_LOCK_OPS'
129 | BUILD_LOCK_OPS(read, rwlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c:80:26: warning: no previous prototype for '__raw_read_lock_irqsave' [-Wmissing-prototypes]
80 | unsigned long __lockfunc __raw_##op##_lock_irqsave(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:129:1: note: in expansion of macro 'BUILD_LOCK_OPS'
129 | BUILD_LOCK_OPS(read, rwlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c:98:17: warning: no previous prototype for '__raw_read_lock_irq' [-Wmissing-prototypes]
98 | void __lockfunc __raw_##op##_lock_irq(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:129:1: note: in expansion of macro 'BUILD_LOCK_OPS'
129 | BUILD_LOCK_OPS(read, rwlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c:103:17: warning: no previous prototype for '__raw_read_lock_bh' [-Wmissing-prototypes]
103 | void __lockfunc __raw_##op##_lock_bh(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:129:1: note: in expansion of macro 'BUILD_LOCK_OPS'
129 | BUILD_LOCK_OPS(read, rwlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c:68:17: warning: no previous prototype for '__raw_write_lock' [-Wmissing-prototypes]
68 | void __lockfunc __raw_##op##_lock(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:130:1: note: in expansion of macro 'BUILD_LOCK_OPS'
130 | BUILD_LOCK_OPS(write, rwlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c:80:26: warning: no previous prototype for '__raw_write_lock_irqsave' [-Wmissing-prototypes]
80 | unsigned long __lockfunc __raw_##op##_lock_irqsave(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:130:1: note: in expansion of macro 'BUILD_LOCK_OPS'
130 | BUILD_LOCK_OPS(write, rwlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c:98:17: warning: no previous prototype for '__raw_write_lock_irq' [-Wmissing-prototypes]
98 | void __lockfunc __raw_##op##_lock_irq(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:130:1: note: in expansion of macro 'BUILD_LOCK_OPS'
130 | BUILD_LOCK_OPS(write, rwlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c:103:17: warning: no previous prototype for '__raw_write_lock_bh' [-Wmissing-prototypes]
103 | void __lockfunc __raw_##op##_lock_bh(locktype##_t *lock) \
| ^~~~~~
kernel/locking/spinlock.c:130:1: note: in expansion of macro 'BUILD_LOCK_OPS'
130 | BUILD_LOCK_OPS(write, rwlock);
| ^~~~~~~~~~~~~~
kernel/locking/spinlock.c: In function '_raw_write_lock_nested':
>> kernel/locking/spinlock.c:306:9: error: implicit declaration of function '__raw_write_lock_nested'; did you mean '_raw_write_lock_nested'? [-Werror=implicit-function-declaration]
306 | __raw_write_lock_nested(lock, subclass);
| ^~~~~~~~~~~~~~~~~~~~~~~
| _raw_write_lock_nested
cc1: some warnings being treated as errors
vim +306 kernel/locking/spinlock.c
303
304 void __lockfunc _raw_write_lock_nested(rwlock_t *lock, int subclass)
305 {
> 306 __raw_write_lock_nested(lock, subclass);
307 }
308 EXPORT_SYMBOL(_raw_write_lock_nested);
309 #endif
310
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip