Re: Removal of config MACH_FSG and dead reference in LEDS_FSG

From: Linus Walleij
Date: Sun Nov 21 2021 - 18:04:15 EST


On Fri, Nov 12, 2021 at 8:59 AM Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote:

> Your commit b71377b3e1e0 ("ARM: ixp4xx: Delete the Freecom FSG-3
> boardfiles") removes the config MACH_FSG. Hence, the config LEDS_FSG
> and its corresponding driver leds-fsg.c is effectively not selectable.
> I do not know much about how with device trees we ensure that specific
> drivers are selected, or how Kconfig build dependencies are combined
> with device trees properly here. So, I do not know what the right
> patch is here.
>
> Was it intended that this code is now made obsolete? Can this driver
> really be deleted?

Oops no.

> Or does it require just some further adjustment to make the leds-fsg
> driver productive again?

Yes. I'll look into it!

Yours,
Linus Walleij