Re: [PATCH 4/4] platform/x86: Add Intel Software Defined Silicon driver

From: Greg KH
Date: Mon Nov 22 2021 - 01:21:53 EST


On Sun, Nov 21, 2021 at 09:18:25AM -0800, David E. Box wrote:
> > These sysfs attributes are crazy. Who has audited them to be correct
> > and work properly? It feels like there are just buffer overflows
> > waiting to be exploited in them due to the reading/writing of raw memory
> > buffers all over the place.
>
> Agree with the concern. I can submit the tests that were used. Is selftests the
> best place?

Yes.

> > Where is the userspace tool that uses these files?
>
> The tool will be published in the same github repo as the spec once the driver
> is ready.

Isn't the driver "ready" if you are asking for it to be accepted
here? Why isn't it published already so we can see if it actually is
tested?

thanks,

greg k-h