Re: [PATCH] x86/paravirt: Fix build PARAVIRT_XXL=y without XEN_PV

From: Juergen Gross
Date: Mon Nov 22 2021 - 07:55:30 EST

On 20.11.21 02:23, Lai Jiangshan wrote:
On Fri, Nov 19, 2021 at 6:20 PM Kirill A. Shutemov <kirill@xxxxxxxxxxxxx> wrote:

It is part of what CONFIG_PARAVIRT_XXL was designed for to enable

That's very vague statement.

Could you elaborate on what is wrong with proposed fix?

Although CONFIG_PARAVIRT_XXL is enabled only when XEN, but they are
separated configs. There is no wrong with the patch, but it is not
justified to narrow the scope of INTERRUPT_RETURN.

xen_iret is defined only with CONFIG_XEN_PV, so using that in
INTERRUPT_RETURN only in case CONFIG_XEN_PV is defined is absolutely
the right thing to do.

In case another user of INTERRUPT_RETURN would come up, it would
need to be changed again anyway.


Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature