Re: [PATCH 1/1] perf arm-spe: extend Arm SPE test script with regression testing

[German Gomez]

On 12/11/2021 16:20, German Gomez wrote:
> Extend the test_arm_spe.sh script to test for regressions in the
> decoding flow of Arm SPE samples. In order to support the tests, a set
> of perf.data files has been generated offline and is being hosted under
> tools/perf/tests/shell/test_arm_spe.tgz:
>
> (See perf report --header-only to see the actual commands used)

Looking back at this patch, I don't think it can be applied as is. I
notice that the docs for the --itrace argument aren't up to date (it
says the default is --itrace=ibxwpe but lately it has changed ([1] &
[2]). The value of --itrace should be locked in the test script.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/Documentation/itrace.txt?id=136057256686de39cc3a07c2e39ef6bc43003ff6#n26
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/perf/util/auxtrace.c?id=136057256686de39cc3a07c2e39ef6bc43003ff6#n1335

>
>   - test_arm_spe.tgz
>     `- arm_spe_decode_contextidr.data
>     `- arm_spe_decode_contextidr.data.inject
>     `- arm_spe_decode_switch_events.data
>     `- arm_spe_decode_switch_events.data.inject
>
> [...]