Re: [RFC PATCH v1 0/1] Create 'Reported:' and 'Reviewed:' tags for links in commit messages
From: Konstantin Ryabitsev
Date: Mon Nov 22 2021 - 10:12:40 EST
On Mon, Nov 22, 2021 at 08:33:41AM +0100, Thorsten Leemhuis wrote:
> The following patch proposes to create two new tags for mentioning links in
> commit messages. They are meant to make it obvious what provided links are
> about, which is useful for both users and scripts studying commits.
>
> The new tag 'Reported:' is meant to be used for linking to bug reports, while
> 'Reviewed:' should point to the last review of the patch in question. They
> supplement 'Link:', which until now has been used for these two as well as other
> purposes; it stays around for the latter use case, for example for links to PDFs
> or webpages with background information relevant for the patch.
As an alternative, I can offer that we continue to use Link: trailers with
extra data following the hashtag, as is already done for other trailers:
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215101 #report
Link: https://lore.kernel.org/r/fobarbaz.5551212@localhost #review
Note, that this merely for completeness, not in opposition to the proposal. I
find the "Link:" trailer to be semantically redundant, since what follows is
already clearly a hyperlink. Adding "Link: " in front of it is only necessary
for consistency and machine parsing reasons.
Regards,
-K