RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml

[Joakim Zhang]

Hi Peng,

> -----Original Message-----
> From: Peng Fan <peng.fan@xxxxxxx>
> Sent: 2021年11月23日 17:29
> To: Joakim Zhang <qiangqing.zhang@xxxxxxx>; Peng Fan (OSS)
> <peng.fan@xxxxxxxxxxx>; robh+dt@xxxxxxxxxx; Aisheng Dong
> <aisheng.dong@xxxxxxx>; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx
> Cc: kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
> 
> > Subject: RE: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
> >
> >
> > Hi Peng,
> >
> > Thanks a lot for helping upstream this patch set.
> >
> > For this change, have you run 'make dtbs_check'? I remember that split
> > them to pass dtbs_check when convert it into yaml.
> 
> " arch/arm/boot/dts/imx6dl-nitrogen6x.dt.yaml:
> ethernet@2188000: More than one condition true in oneOf schema: "
> 
> But this is not introduced by my patch, it already there even drop my patch.
> 
> I not see other issues.


For this error: ethernet@2188000: More than one condition true in oneOf schema:

This is caused by ['interrupts'] and ['interrupts-extended'], this should be a common limitation, this is a known warning. 
         'oneOf': [{'required': ['interrupts']},
                   {'required': ['interrupts-extended']}],

After applying this patch, I verified on both arm and arm64 platforms, indeed there is no regression targets to ['compatible']. I am okay with this patch, sorry for this inconvenience.

Best Regards,
Joakim Zhang
> Thanks,
> Peng.
> 
> >
> > Best Regards,
> > Joakim Zhang
> > > -----Original Message-----
> > > From: Peng Fan (OSS) <peng.fan@xxxxxxxxxxx>
> > > Sent: 2021年11月20日 19:58
> > > To: robh+dt@xxxxxxxxxx; Aisheng Dong <aisheng.dong@xxxxxxx>;
> Joakim
> > > Zhang <qiangqing.zhang@xxxxxxx>; davem@xxxxxxxxxxxxx;
> > kuba@xxxxxxxxxx;
> > > shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx
> > > Cc: kernel@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; dl-linux-imx
> > > <linux-imx@xxxxxxx>; netdev@xxxxxxxxxxxxxxx;
> > > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Peng Fan <peng.fan@xxxxxxx>
> > > Subject: [PATCH 1/4] dt-bindings: net: fec: simplify yaml
> > >
> > > From: Peng Fan <peng.fan@xxxxxxx>
> > >
> > > i.MX7D, i.MX8MQ and i.MX8QM are compatible with i.MX6SX, so no need
> > to
> > > split them into three items.
> > >
> > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > > ---
> > >  Documentation/devicetree/bindings/net/fsl,fec.yaml | 8 ++------
> > >  1 file changed, 2 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > index eca41443fcce..dbf63a9c2a46 100644
> > > --- a/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > +++ b/Documentation/devicetree/bindings/net/fsl,fec.yaml
> > > @@ -39,9 +39,8 @@ properties:
> > >        - items:
> > >            - enum:
> > >                - fsl,imx7d-fec
> > > -          - const: fsl,imx6sx-fec
> > > -      - items:
> > > -          - const: fsl,imx8mq-fec
> > > +              - fsl,imx8mq-fec
> > > +              - fsl,imx8qm-fec
> > >            - const: fsl,imx6sx-fec
> > >        - items:
> > >            - enum:
> > > @@ -50,9 +49,6 @@ properties:
> > >                - fsl,imx8mp-fec
> > >            - const: fsl,imx8mq-fec
> > >            - const: fsl,imx6sx-fec
> > > -      - items:
> > > -          - const: fsl,imx8qm-fec
> > > -          - const: fsl,imx6sx-fec
> > >        - items:
> > >            - enum:
> > >                - fsl,imx8qxp-fec
> > > --
> > > 2.25.1