Re: [PATCH v5 3/4] mtd: core: protect access to MTD devices while in suspend

From: Boris Brezillon
Date: Tue Nov 23 2021 - 08:07:26 EST


On Tue, 23 Nov 2021 13:50:12 +0100
Sean Nyekjaer <sean@xxxxxxxxxx> wrote:

> @Boris do we need to do something similar here to what we did with the
> mtdconcat stuff?

Absolutely, physmasp subdevices are never initialized/registered, so
you can't call any of the mtd helpers taking the suspend lock on those.
I guess it'd be better to call mtd_suspend/resume() on the concat device
in though:

static void physmap_flash_shutdown(struct platform_device *dev)
{
struct physmap_flash_info *info = platform_get_drvdata(dev);

mtd_suspend(info->cmtd);
}