Re: Re: [PATCH] ARM: dts: sun8i: Adjust power key nodes

From: Jernej Škrabec
Date: Tue Nov 23 2021 - 11:44:40 EST


Hi!

Dne torek, 23. november 2021 ob 11:32:19 CET je Maxime Ripard napisal(a):
> Hi,
>
> On Mon, Nov 22, 2021 at 10:36:37PM +0100, Jernej Skrabec wrote:
> > Several H3 and one H2+ board have power key nodes, which are slightly
> > off. Some are missing wakeup-source property and some have BTN_0 code
> > assigned instead of KEY_POWER.
> >
> > Adjust them, so they can function as intended by designer.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
> > [BananaPi M2 Zero changes]
> > Signed-off-by: Michael Klein <michael@xxxxxxxxxxxx>
>
> This looks a bit weird. If Michael is the author, then his SoB should be
> here first and mentioned either in From or Co-developed-by.
>
> If you are, I'm not sure why he's mentioned?

I'm main author and Michael just adapted BananaPi M2 Zero DT based on my
changes. What is preferred way to mark him as co-author?

Best regards,
Jernej

>
> Maxime
>