Re: [PATCH v6] clk: Add write operation for clk_parent debugfs node

[Michael Turquette]

On Mon, Nov 22, 2021 at 10:03 AM Sam Protsenko
<semen.protsenko@xxxxxxxxxx> wrote:
>
> On Tue, 19 Oct 2021 at 16:32, Sam Protsenko <semen.protsenko@xxxxxxxxxx> wrote:
> >
> > On Wed, 13 Oct 2021 at 21:04, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> > >
> > > Hi Sam,
> > >
> > > On Wed, Oct 13, 2021 at 2:20 PM Sam Protsenko
> > > <semen.protsenko@xxxxxxxxxx> wrote:
> > > >
> > > > Useful for testing mux clocks. One can write the index of the parent to
> > > > be set into clk_parent node, starting from 0. Example
> > > >
> > > >     # cd /sys/kernel/debug/clk/mout_peri_bus
> > > >     # cat clk_possible_parents
> > > >       dout_shared0_div4 dout_shared1_div4
> > > >     # cat clk_parent
> > > >       dout_shared0_div4
> > > >     # echo 1 > clk_parent
> > > >     # cat clk_parent
> > > >       dout_shared1_div4
> > > >
> > > > CLOCK_ALLOW_WRITE_DEBUGFS has to be defined in drivers/clk/clk.c in
> > > > order to use this feature.
> > > >
> > > > Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
> > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > >
> > > This is useful, thanks:
> > >
> > > Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>
> >
> > Hi Michael, Stephen,
> >
> > If there are no outstanding comments, can you please take this one?
> >
>
> Bump.

Looks good to me.

Acked-by: Michael Turquette <mturquette@xxxxxxxxxxxx>

Stephen, can you take it into your tree?

Best,
Mike

>
> > Thanks!



-- 
Michael Turquette
CEO - Los Angeles, CA
http://baylibre.com/