Re: [PATCH 01/11] ASoC: cs35l41: Set the max SPI speed for the whole device

From: Charles Keepax
Date: Tue Nov 23 2021 - 13:04:25 EST


On Tue, Nov 23, 2021 at 04:31:39PM +0000, Lucas Tanure wrote:
> Higher speeds are only supported when PLL is enabled, but
> the current driver doesn't enable PLL outside of stream
> use cases, so better to set the lowest SPI speed accepted
> by the entire device.
>
> Move the current frequency set to the spi sub-driver so
> the whole device can benefit from that speed.
>
> spi-max-frequency property could be used, but ACPI systems don't
> support it, so by setting it in the spi sub-driver probe
> both Device Trees and ACPI systems are supported.
>
> Signed-off-by: Lucas Tanure <tanureal@xxxxxxxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles