Re: [RFC v1 1/8] crash: fix minor typo/bug in debug message
From: Baoquan He
Date: Tue Nov 23 2021 - 20:17:53 EST
On 11/18/21 at 12:49pm, Eric DeVolder wrote:
> The pr_debug() intends to display the memsz member, but the
> parameter is actually the bufsz member (which is already
> displayed). Correct this to display memsz value.
>
> Signed-off-by: Eric DeVolder <eric.devolder@xxxxxxxxxx>
> ---
> arch/x86/kernel/crash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
> index e8326a8d1c5d..9730c88530fc 100644
> --- a/arch/x86/kernel/crash.c
> +++ b/arch/x86/kernel/crash.c
> @@ -407,7 +407,7 @@ int crash_load_segments(struct kimage *image)
> }
> image->elf_load_addr = kbuf.mem;
> pr_debug("Loaded ELF headers at 0x%lx bufsz=0x%lx memsz=0x%lx\n",
> - image->elf_load_addr, kbuf.bufsz, kbuf.bufsz);
> + image->elf_load_addr, kbuf.bufsz, kbuf.memsz);
Good catch, thx.
Acked-by: Baoquan He <bhe@xxxxxxxxxx>
>
> return ret;
> }
> --
> 2.27.0
>