Re: [PATCH] notifier: Return an error when a callback has already been registered

[Sebastian Andrzej Siewior]

On 2021-12-02 15:23:36 [+0100], Borislav Petkov wrote:
> On Thu, Dec 02, 2021 at 03:16:30PM +0100, Sebastian Andrzej Siewior wrote:
> > >  	while ((*nl) != NULL) {
> > > -		if (unlikely((*nl) == n)) {
> > > -			WARN(1, "double register detected");
> > > -			return 0;
> > 
> > This could be s/0/-EEXIST/ or do I miss something?
> 
> It is...
…
> > > -		}
> > > +		if (unlikely((*nl) == n))
> > > +			return -EEXIST;
> 			^^^^^^^^^^^^^^^
> 
> ... right here.

I meant without the extra function. I'm fine either way, just curious :)

Sebastian