Re: [PATCH] ARM: dts: at91: sama5d2_xplained: remove PA11__SDMMC0_VDDSEL from pinctrl

From: Eugen.Hristev
Date: Wed Dec 08 2021 - 06:28:09 EST


On 12/8/21 1:22 PM, Nicolas Ferre wrote:
> On 26/10/2021 at 15:20, Eugen Hristev wrote:
>> From: Mihai Sain <mihai.sain@xxxxxxxxxxxxx>
>>
>> I/O voltage for eMMC is always 3.3V because PA11__SDMMC0_VDDSEL is
>> tied with 10K resistor to GND. U13 switch S1 is always selected as
>> voltage rail of 3.3V for VCCQ power pin from MPU controller and eMMC
>> flash.
>> Removing PA11 from pinctrl because it remains unused.
>>
>> Signed-off-by: Mihai Sain <mihai.sain@xxxxxxxxxxxxx>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@xxxxxxxxxxxxx>

You can also add my
Reviewed-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>

and also
Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>
because I sent the patch.


>
> Thanks, best regards,
>   Nicolas
>
>> ---
>>   arch/arm/boot/dts/at91-sama5d2_xplained.dts | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> index b1e854f658de..9bf2ec0ba3e2 100644
>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> @@ -66,7 +66,7 @@ sdmmc0: sdio-host@a0000000 {
>>               pinctrl-names = "default";
>>               pinctrl-0 = <&pinctrl_sdmmc0_default>;
>>               non-removable;
>> -            mmc-ddr-1_8v;
>> +            mmc-ddr-3_3v;
>>               status = "okay";
>>           };
>> @@ -619,10 +619,9 @@ cmd_data {
>>                           bias-disable;
>>                       };
>> -                    ck_cd_rstn_vddsel {
>> +                    ck_cd_rstn {
>>                           pinmux = <PIN_PA0__SDMMC0_CK>,
>>                                <PIN_PA10__SDMMC0_RSTN>,
>> -                             <PIN_PA11__SDMMC0_VDDSEL>,
>>                                <PIN_PA13__SDMMC0_CD>;
>>                           bias-disable;
>>                       };
>>
>
>