Re: [PATCH v1 04/11] i2c: designware-pci: Convert to use dev_err_probe()

From: Jarkko Nikula
Date: Wed Dec 08 2021 - 07:21:14 EST


On 12/7/21 21:21, Andy Shevchenko wrote:
+ if (id->driver_data >= ARRAY_SIZE(dw_pci_controllers))
+ return dev_err_probe(dev, -EINVAL, "invalid driver data %ld\n", id->driver_data);
I know checkpatch.pl doesn't complain this but for my taste readability would be a bit better if error causing id->driver_data is split into another line.

Jarkko