Re: [PATCH 1/9] ext4: Switch to kvfree_rcu() API

[Uladzislau Rezki]

+ linux-ext4@xxxxxxxxxxxxxxx

On Wed, Nov 24, 2021 at 12:03 PM Uladzislau Rezki (Sony)
<urezki@xxxxxxxxx> wrote:
>
> From: Uladzislau Rezki <uladzislau.rezki@xxxxxxxx>
>
> Instead of invoking a synchronize_rcu() to free a pointer
> after a grace period we can directly make use of new API
> that does the same but in more efficient way.
>
> CC: "Theodore Ts'o" <tytso@xxxxxxx>
> Signed-off-by: Uladzislau Rezki <uladzislau.rezki@xxxxxxxx>
> ---
>  fs/ext4/super.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 4e33b5eca694..111b0498a232 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1886,8 +1886,7 @@ static int clear_qf_name(struct super_block *sb, int qtype)
>                 return -1;
>         }
>         rcu_assign_pointer(sbi->s_qf_names[qtype], NULL);
> -       synchronize_rcu();
> -       kfree(old_qname);
> +       kvfree_rcu(old_qname);
>         return 1;
>  }
>  #endif
> --
> 2.30.2
>


-- 
Uladzislau Rezki