Re: [PATCH] binder: fix pointer cast warning

From: Randy Dunlap
Date: Wed Dec 08 2021 - 10:00:09 EST




On 12/8/21 02:09, Christian Brauner wrote:
> On Tue, Dec 07, 2021 at 01:24:42PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>>
>> binder_uintptr_t is not the same as uintptr_t, so converting it into a
>> pointer requires a second cast:
>>
>> drivers/android/binder.c: In function 'binder_translate_fd_array':
>> drivers/android/binder.c:2511:28: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>> 2511 | sender_ufda_base = (void __user *)sender_uparent->buffer + fda->parent_offset;
>> | ^
>>
>> Fixes: 656e01f3ab54 ("binder: read pre-translated fds from sender buffer")
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>> ---
>
> Looks good.
> Acked-by: Christian Brauner <christian.brauner@xxxxxxxxxx>
>

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested

thanks.

--
~Randy