Re: [PATCH] pinctrl: at91: allow use of of gpio-line-names property

From: Andy Shevchenko
Date: Wed Dec 08 2021 - 11:29:54 EST


On Wed, Dec 8, 2021 at 4:51 PM Alexander Dahl <ada@xxxxxxxxxxx> wrote:
> Am Tue, Dec 07, 2021 at 12:32:03AM +0100 schrieb Peter Rosin:
> > If no line name is given (by not having a gpio-line-names property,
> > or by having empty "" strings for some lines), fall back to the
> > existing pioC12-style line name scheme.
> >
> > It is useful to be able to explicitly name lines from the schematics
> > or its function, rather than having the MCU names forced upon every
> > user.
>
> +1 from me.
>
> I asked about this some months ago, but I saw no clear
> direction in the discussion. So for reference:
>
> https://lore.kernel.org/linux-gpio/946021874.11132.1615900079722@xxxxxxxxxxxxxxxxx/

Thanks for the reminder. AFAICS from that discussion we kinda agreed
on the names being excluded from the ABI path. Hence there is good and
bad news.

Bad one: NAK to this patch.
Good one: Please, fix this in the gpiolib respective functions to make
it once for all.

Disclaimer, I'm not a maintainer of this subsystem, I might be
perfectly wrong in my understanding of the state of affairs, let's
hear what Linus and Bart can tell us about the subject. Above are just
my wishes as a contributor to and consumer of this subsystem on how
things should be done.

--
With Best Regards,
Andy Shevchenko