Re: [PATCH v2 2/2] misc: dice: Add driver to forward secrets to userspace

[Pavel Machek]

Hi!

> > +	memzero_explicit(kaddr, dice_rmem->size);
> > +	devm_memunmap(dice_misc.this_device, kaddr);
> 
> Do you really need to call memzero_explicit()?  This isn't "local"
> memory, if the compiler "optimizes away" a normal call, it would be
> _VERY_ broken.

For clearing secrets, I believe memzero_explicit is nice
documentation.

Best regards,
								Pavel
								
-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: PGP signature