Re: [PATCH v3 2/3] block: don't delete queue kobject before its children

From: Bart Van Assche
Date: Thu Dec 09 2021 - 18:26:38 EST

Next message: Alex Komrakov: "[PATCH 1/1] Calculate the monotonic clock from the timespec clock to genereate pps PPS elapsed realtime event value and stores the result into /sys/class/pps/pps0/assert_elapsed."
Previous message: Florian Fainelli: "Re: [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset to YAML"
In reply to: Eric Biggers: "Re: [PATCH v3 2/3] block: don't delete queue kobject before its children"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 12/9/21 3:17 PM, Eric Biggers wrote:

On Thu, Dec 09, 2021 at 02:38:02PM -0800, Bart Van Assche wrote:

On 12/7/21 5:35 PM, Eric Biggers wrote:

+ /* Now that all child objects were deleted, the queue can be deleted. */

Shouldn't the present tense be used above (were -> are)? Anyway:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>

"deleted" is an action here, not a state. I think it's fine as-is, but maybe
you would prefer the following?

/* Now that we've deleted all child objects, we can delete the queue. */

Both alternatives work for me.

Thanks,

Bart.

Next message: Alex Komrakov: "[PATCH 1/1] Calculate the monotonic clock from the timespec clock to genereate pps PPS elapsed realtime event value and stores the result into /sys/class/pps/pps0/assert_elapsed."
Previous message: Florian Fainelli: "Re: [PATCH v3 02/15] dt-bindings: reset: Convert Broadcom STB reset to YAML"
In reply to: Eric Biggers: "Re: [PATCH v3 2/3] block: don't delete queue kobject before its children"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]