Re: [PATCHv2] net/batman-adv:remove unneeded variable

From: Sven Eckelmann
Date: Fri Dec 10 2021 - 04:51:54 EST


On Friday, 10 December 2021 10:42:06 CET cgel.zte@xxxxxxxxx wrote:
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
>
> Return status directly from function called.
> change since v1: zealci@xxxxxxxxxx
> v2: zealci@xxxxxxxxxx
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> ---

This is wrong:

1. the patch was already applied
2. the patch history doesn't belong in the commit message
3. there is still an alignment problem
4. if you use -v in git-format-patch then it should be "PATCH v2" and not
"PATCHv2" (otherwise it will not be parsed correctly by patchwork)
5. The alignment problem is still there
6. the subject is also not following the normal formatting style

Kind regards,
Sven

Attachment: signature.asc
Description: This is a digitally signed message part.