Re: [PATCH v2 13/18] crypto: testmgr - add DH test vectors for key generation

From: Hannes Reinecke
Date: Fri Dec 10 2021 - 06:37:18 EST


On 12/9/21 10:03 AM, Nicolai Stange wrote:
> Now that all DH implementations support ephemeral key generation triggered
> by passing a ->key_size of zero to ->set_secret(), it's certainly
> worthwhile to build upon the testmgr's do_test_kpp() ->genkey facility to
> test it.
>
> Add two ->genkey DH test vectors to the testmgr, one for the RFC 7919
> ffdhe3072 group and another one for the RFC 3526 modp2048 group. For the
> resp. party B's keypair, just reuse the already available values
> previously specified for party A in the existing known answer tests. This
> will enable the compiler to merge these rather large data strings.
>
> Signed-off-by: Nicolai Stange <nstange@xxxxxxx>
> ---
> crypto/testmgr.h | 164 +++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 164 insertions(+)
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer