Re: [PATCH] selftests: mptcp: remove duplicate include in mptcp_inq.c

From: Jakub Kicinski
Date: Fri Dec 10 2021 - 09:54:51 EST


On Fri, 10 Dec 2021 10:58:27 +0100 Matthieu Baerts wrote:
> Hi Ye,
>
> On 10/12/2021 08:14, cgel.zte@xxxxxxxxx wrote:
> > From: Ye Guojin <ye.guojin@xxxxxxxxxx>
> >
> > 'sys/ioctl.h' included in 'mptcp_inq.c' is duplicated.
>
> Good catch, the modification looks good to me:
>
> Reviewed-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>
>
>
> This patch is for "net-next" tree as it fixes an issue introduced by a
> patch only in this tree:
>
> Fixes: b51880568f20 ("selftests: mptcp: add inq test case")
>
> Regarding the commit message, please next time include the Fixes tag and
> mention for which tree it is for in the FAQ [1], e.g. [PATCH net-next].
>
>
> @David/Jakub: do you prefer a v2 with these modifications or is it fine
> to apply this small patch directly in net-next tree?

v1 is fine. Let me apply it right away and do the edits before I forget
they are needed..