Re: [EXT] Re: [PATCH net-next] net: stmmac: bump tc when get underflow error from DMA descriptor

From: Jakub Kicinski
Date: Fri Dec 10 2021 - 11:06:43 EST


On Fri, 10 Dec 2021 03:11:16 +0000 Xiaoliang Yang wrote:
> > > 5 queues with FIFO cut-through mode can work well after applying this patch.
> >
> > This never worked, correct? It's not a regression fix?
>
> Yes, it's never worked when the underflow error is observed in the
> case of NFS boot on i.mx8mp. I'm not sure if other SoC have same
> issue in this case, but I think it's necessary to increase the
> threshold value in case of underflow error.

Oh, so NFS boot works for the most part on i.mx8mp but under certain
conditions (or with certain configuration?) this error can be observed
and the boot will fail?

> Do you mean that I need to send the patch as a bug fix to net branch?

Your call, if you would like for the patch to go to stable and LTS
releases -- then it need to be resent for net with a Fixes tag.

LMK if you prefer net or net-next.