Re: [PATCH] spi: Fix incorrect cs_setup delay handling
From: Mark Brown
Date: Fri Dec 10 2021 - 11:39:23 EST
On Sat, Dec 11, 2021 at 01:32:06AM +0900, Hector Martin wrote:
> On 11/12/2021 01.21, Mark Brown wrote:
> > This needs a better changelog, there's multiple delays being handled
> > here and it's not clear from this which are affected here or what the
> > problem is.
> cs_setup is affected, I thought at least that was clear from the patch
> summary :-)
This should be in the commit message, the subject line of the e-mail
isn't super visible when people are reviewing - basically, the body of
the commit message should make sense standalone.
> If you prefer, I can resend it with a reference to the spi.h comment.
Yes, please resend with a clear commit message.
Attachment:
signature.asc
Description: PGP signature