Re: [PATCH v8 24/40] x86/compressed/acpi: move EFI system table lookup to helper

From: Dave Hansen
Date: Fri Dec 10 2021 - 13:54:43 EST


On 12/10/21 7:43 AM, Brijesh Singh wrote:
> +/*
> + * Helpers for early access to EFI configuration table
> + *
> + * Copyright (C) 2021 Advanced Micro Devices, Inc.
> + *
> + * Author: Michael Roth <michael.roth@xxxxxxx>
> + */

It doesn't seem quite right to slap this copyright on a file that's full
of content that came from other files. It would be one thing if
arch/x86/boot/compressed/acpi.c had this banner in it already. Also, a
bunch of the lines in this file seem to come from:

commit 33f0df8d843deb9ec24116dcd79a40ca0ea8e8a9
Author: Chao Fan <fanc.fnst@xxxxxxxxxxxxxx>
Date: Wed Jan 23 19:08:46 2019 +0800